Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands on skill cards #2132

Merged
merged 63 commits into from
Feb 26, 2025
Merged

Commands on skill cards #2132

merged 63 commits into from
Feb 26, 2025

Conversation

IanCal
Copy link
Contributor

@IanCal IanCal commented Feb 10, 2025

This covers manually approved/applied commands.

Key points

  • Commands can be added to skill cards. Each one has a flag for whether it requires user approval (for use in a following PR but it's important it's nested) and a function name.
  • The function name is constructed from the coderef, so the name is stable and the same command added from two different skills is the same.
  • The schemas are important only for the aibot, so the host adds them to the room when required but does not
  • There are some potential loading issues around skill cards, there is an async call inside a sync getter. This may be responsible for other cases where some things are showing or not.

Next steps:

  • Bring back the test for AIbot
  • Add host test
  • Neaten the hashing function in skill cards
  • Update all commands to export with the name as well
  • Cache commands that get added to the room?

Copy link

github-actions bot commented Feb 10, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 32s ⏱️ -14s
784 tests +1  782 ✔️ +1  2 💤 ±0  0 ±0 
789 runs  +1  787 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit e218961. ± Comparison against base commit 62f68bc.

♻️ This comment has been updated with latest results.

@IanCal IanCal marked this pull request as ready for review February 11, 2025 13:46
@IanCal
Copy link
Contributor Author

IanCal commented Feb 11, 2025

Commands on skills lets us add things like grounding with wikidata easily
Screencast from 11-02-25 15:02:35.webm

@IanCal IanCal requested a review from lukemelia February 11, 2025 16:44
@lukemelia lukemelia force-pushed the return-of-the-skill-commands branch from c1a24e0 to b2f7b26 Compare February 20, 2025 05:10
@lukemelia lukemelia force-pushed the return-of-the-skill-commands branch from b2f7b26 to 8b99982 Compare February 20, 2025 06:40
@lukemelia lukemelia force-pushed the return-of-the-skill-commands branch 2 times, most recently from 5b600fe to 7b8b16e Compare February 26, 2025 21:08
@lukemelia lukemelia force-pushed the return-of-the-skill-commands branch from 7b8b16e to e218961 Compare February 26, 2025 21:34
@lukemelia lukemelia merged commit ae0de84 into main Feb 26, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants