Skip to content

use autosave rhs for spec #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 19, 2025
Merged

use autosave rhs for spec #2143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4ad9111
refactor to use prerendered and introduce autosave
tintinthong Feb 13, 2025
074352e
use prerendering
tintinthong Feb 14, 2025
a963be8
load card from the root of spec preview and enable auto save
tintinthong Feb 14, 2025
d469022
fix test
tintinthong Feb 14, 2025
02b1ff9
get test to work for auto save
tintinthong Feb 14, 2025
37e861b
fix lint
tintinthong Feb 14, 2025
7a7b749
fix lint
tintinthong Feb 14, 2025
773aeb1
Fix lint and loading state to be more clear
tintinthong Feb 15, 2025
a3aaa4d
fix lint and remove stale loading
tintinthong Feb 15, 2025
db10050
fix scrolling issue
tintinthong Feb 15, 2025
2fdd54b
fix loading on title
tintinthong Feb 15, 2025
34cda6b
remove unnecessary console.log
tintinthong Feb 18, 2025
eed0784
Merge branch 'main' into enable-rhs-panel-to-get-autosave-changes
tintinthong Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/base/spec.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ export class Spec extends CardDef {
<BookOpenText width='20' height='20' role='presentation' />
<h2 id='readme'>Read Me</h2>
</header>
<@fields.readMe />
<div data-test-readme>
<@fields.readMe />
</div>
</section>
<section class='examples section'>
<header class='row-header' aria-labelledby='examples'>
Expand Down
Loading