Show the attached file in message bubble #2153
Conversation
FadhlanR
commented
Feb 17, 2025
FadhlanR
commented
Host Test Results 1 files ±0 1 suites ±0 23m 12s ⏱️ +31s Results for commit 91bbe05. ± Comparison against base commit 22ebcca. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
We decided to have a separate component for this because we'll be pulling data from different fields, and we want to avoid too many conditions. @jurgenwerk and I discussed it here: #2126 (comment). |
| @@ -215,6 +218,14 @@ export default class AiAssistantMessage extends Component<Signature> { | |||
| </div> | |||
| {{/if}} | |||
|
|
|||
| {{#if @resources.files.length}} | |||
| <div class='cards' data-test-message-files> | |||
There was a problem hiding this comment.
Class name cards implies there will be cards here, but actually there are files. Would be good to rename the class.
@jurgenwerk here's the screenshot:
|
|
The vertical and horizontal padding between pills is different which can be improved. And this looks different compared to how this collection is shown in the attachment picker. The pills are displayed inline there, regardless of its type. I would expect it to look the same here. |
There was a problem hiding this comment.
Agree with @jurgenwerk about the visual treatment, otherwise looks good
