Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember playground format via local storage #2155

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

burieberry
Copy link
Contributor

@burieberry burieberry commented Feb 17, 2025

  • in playground panel, the selected card preview format is now remembered

Copy link

github-actions bot commented Feb 17, 2025

Host Test Results

    1 files  ±  0      1 suites  ±0   22m 52s ⏱️ +57s
766 tests +63  764 ✔️ +63  2 💤 +1  0  - 1 
771 runs  +64  769 ✔️ +64  2 💤 +1  0  - 1 

Results for commit cc1dd6d. ± Comparison against base commit 818be4d.

This pull request removes 1 and adds 64 tests. Note that renamed tests count towards both.
Chrome 133.0 ‑ Global error: Uncaught Error: status: 500 -           . unexpected exception in realm TypeError: Failed to fetch at http://localhost:7357/assets/chunk.79fc60c15c7eda0270ed.js, line 464082  While executing test: Acceptance | code submode tests > single realm: updates values in preview panel must be represented in editor panel 
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: card preview live updates when index changes
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: card preview live updates when there is a change in module
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: card preview live updates with error
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: card-catalog does not offer to "create new card" when editing linked fields in code mode
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: closes the top-most modal first when clicking overlay background
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: monaco editor live updates when index changes
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: remembers open RHS panel via local storage
Chrome 133.0 ‑ Acceptance | code submode tests > single realm: updates values in preview panel must be represented in editor panel
Chrome 133.0 ‑ Acceptance | code submode | recent files tests: displays recent files in base realm
Chrome 133.0 ‑ Acceptance | code submode | recent files tests: recent file links are shown
…

♻️ This comment has been updated with latest results.

@burieberry burieberry force-pushed the cs-7977-remember-playground-format branch from 66b273e to 60cc43f Compare February 17, 2025 15:32
@burieberry burieberry requested a review from a team February 17, 2025 15:34
@jurgenwerk
Copy link
Contributor

jurgenwerk commented Feb 18, 2025

Related question, I am using playground in another branch (#2137) and after refreshing the playground doesn't stay open, I think this would be really helpful to persist too (in case it's not already implemented–I'm not sure if my branch is outdated)

@burieberry
Copy link
Contributor Author

Related question, I am using playground in another branch (#2137) and after refreshing the playground doesn't stay open, I think this would be really helpful to have too (in case it's not already implemented–I'm not sure if my branch is outdated)

Merged #2157 just recently, see if that resolves this. Please report on any issues/ideas for improvement.

@burieberry burieberry merged commit 7b40996 into main Feb 18, 2025
48 checks passed
@jurgenwerk
Copy link
Contributor

@burieberry perfect, thank you.

@burieberry burieberry deleted the cs-7977-remember-playground-format branch April 2, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants