Can create new instance in playground #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
burieberry
commented
Feb 18, 2025
•
burieberry
commented
- separated next step into different pr to prevent blocker on turning feature flag off for playground: Add "create card instance" command #2180 convert create instance to command
burieberry
force-pushed
the
cs-7910-create-instance-in-playground
branch
from
eab8536 to
afbfc16
Compare
habdelra
reviewed
Feb 21, 2025
| }, | ||
| }; | ||
| try { | ||
| let card = await this.cardService.createFromSerialized(doc.data, doc); |
There was a problem hiding this comment.
please use CardResource to create new cards, not the CardService directly. failing to do so will result in an instance that doesn't consistently rerender for live updates
There was a problem hiding this comment.
Updated this to use card-resource. Had some trouble persisting the new card and adding it to recent-cards, so you'll see the note I made in createNew task.
habdelra
requested changes
Feb 21, 2025
There was a problem hiding this comment.
New instances should always be created via CardResource. Here is an example of what that looks like https://github.com/cardstack/boxel/blob/main/packages/host/app/lib/stack-item.ts#L55-L58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.