-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can create new instance in playground #2162
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d5261d
can create new instance in playground
burieberry 9bb04f5
display loading state
burieberry 40e617e
add test
burieberry 0b265bd
Merge remote-tracking branch 'origin/main' into cs-7910-create-instan…
burieberry 32e7999
style tweaks
burieberry afbfc16
lint fix
burieberry 8f0a636
Merge remote-tracking branch 'origin/main' into cs-7910-create-instan…
burieberry e4f0d12
use card-resource to create new instance
burieberry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
// This file is auto-generated by 'pnpm rebuild:icons' | ||
import type { TemplateOnlyComponent } from '@ember/component/template-only'; | ||
|
||
import type { Signature } from './types.ts'; | ||
|
||
const IconComponent: TemplateOnlyComponent<Signature> = <template> | ||
<svg | ||
xmlns='http://www.w3.org/2000/svg' | ||
viewBox='3.5 3.5 17 17' | ||
...attributes | ||
><path | ||
fill='var(--icon-color, currentColor)' | ||
d='M19 11h-6V5a1 1 0 0 0-2 0v6H5a1 1 0 0 0 0 2h6v6a1 1 0 0 0 2 0v-6h6a1 1 0 0 0 0-2Z' | ||
/></svg> | ||
</template>; | ||
|
||
// @ts-expect-error this is the only way to set a name on a Template Only Component currently | ||
IconComponent.name = 'IconPlusThin'; | ||
export default IconComponent; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use CardResource to create new cards, not the CardService directly. failing to do so will result in an instance that doesn't consistently rerender for live updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this to use card-resource. Had some trouble persisting the new card and adding it to recent-cards, so you'll see the note I made in createNew task.