Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create a new RoomResource for the Room component, use the one from MatrixService #2173

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Don't create a new RoomResource for the Room component, use the one from MatrixService #2173

merged 2 commits into from
Feb 19, 2025

Conversation

lukemelia
Copy link
Contributor

No description provided.

@lukemelia lukemelia requested a review from a team February 19, 2025 23:10
@github-actions GitHub Actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   22m 35s ⏱️ -27s
769 tests ±0  767 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
774 runs  ±0  772 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 304b9ff. ± Comparison against base commit 3b2b6f8.

backspace
backspace approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeking: identity map 🙃

@lukemelia lukemelia merged commit 6008560 into main Feb 19, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backspace backspace backspace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemelia @backspace