Allow to search null field on search resources / improve parse query on null handling #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardhjtan
changed the title
richardhjtan
commented
Feb 20, 2025
| module: `${testModuleRealm}friend`, | ||
| name: 'Friend', | ||
| }, | ||
| every: [{ eq: { firstName: 'Mango' } }, { eq: { friend: null } }], |
There was a problem hiding this comment.
From what i test in the CRM app, both { eq: { assignee : null}} or { eq: { 'assignee.id' : null}} able to give the same expected result after the fix
richardhjtan
requested review from
habdelra,
lukemelia,
jurgenwerk and
a team
richardhjtan
force-pushed
the
investigate-link-id
branch
from
4c2b10a to
79fa53e
Compare
burieberry
approved these changes
Feb 20, 2025
tintinthong
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a scenario to get CRM task cards with no assignee when user clicks 'Unassigned' filter
Two layer of issues found with @tintinthong
nullvalue on query, it parses as empty string - so search doc couldn't find any cards of field which hasnullvalueassignee: nullas it gives error about compound field ( NOTE: found this is not valid after fix the first issue and did several tests locally )Solution
strictNullHandlingExamples
Search doc of CRM task card with no assignee
Error when filtering assignee null before the fix
After fix
