Add "create card instance" command #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habdelra
reviewed
Feb 21, 2025
| }, | ||
| }, | ||
| }; | ||
| await this.cardService.createFromSerialized(doc.data, doc); |
There was a problem hiding this comment.
we should really be using the CardResource to make cards, not the CardService directly (it would be great if we could deprecate this so others don't fall into this trap). When you make a card with the CardService directly that means that the card will not be part of the identity map and will not receive live updates, as well as other realy bad side effects.
burieberry
force-pushed
the
cs-8032-create-instance-command
branch
from
f577894 to
4cc0114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for comments regarding usage of card-resource in a command in this way to create a card. If this is not a good idea, maybe this PR is no longer relevant.