Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CardService instance creation warning #2186

Merged
merged 1 commit into from
Feb 21, 2025
Merged

CardService instance creation warning #2186

merged 1 commit into from
Feb 21, 2025

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Feb 21, 2025 •
edited
Loading

Documenting our public service announcement to not create instances from CardService.

@habdelra habdelra requested a review from a team February 21, 2025 15:15
@github-actions GitHub Actions
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   24m 10s ⏱️ +26s
773 tests ±0  771 ✔️ ±0  2 💤 ±0  0 ❌ ±0 
778 runs  ±0  776 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 4b41504. ± Comparison against base commit 05d4cb6.

burieberry
burieberry approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@burieberry burieberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was thinking of doing the same

@habdelra habdelra merged commit febc865 into main Feb 21, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burieberry burieberry burieberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@habdelra @burieberry