Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the bug where switching from module to an instance in code mode would show a loading indicator that never dismisses #2187

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Feb 21, 2025

Fixes this bug where switching from a module to an instance in code module would show a loading indicator that never dismisses.

Before:

loading-bug-before

After:

loading-bug-after2

… would show a loading indicator that never dismisses
Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. thx thiz was annoying

@habdelra habdelra requested a review from a team February 21, 2025 16:26
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   23m 32s ⏱️ +25s
774 tests +1  772 ✔️ +1  2 💤 ±0  0 ±0 
779 runs  +1  777 ✔️ +1  2 💤 ±0  0 ±0 

Results for commit 6073ad7. ± Comparison against base commit febc865.

@habdelra habdelra merged commit 0717b78 into main Feb 21, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants