Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert ai assistant view-code container styles and add snapshot #2199

Merged
merged 7 commits into from
Feb 25, 2025

Conversation

burieberry
Copy link
Contributor

Before:
view-code

After:
view-code

@burieberry burieberry requested review from a team and habdelra February 24, 2025 23:04
Copy link

github-actions bot commented Feb 24, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   23m 43s ⏱️ +19s
777 tests +2  775 ✔️ +3  2 💤 ±0  0 ±0 
782 runs  +2  780 ✔️ +4  2 💤 ±0  0  - 1 

Results for commit 0bfa515. ± Comparison against base commit 0a7099f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@habdelra habdelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait--this breaks the monaco read-only editor when there are code blocks in the AI assistant response.

try asking the AI assistant to give you an javascript class example. or another question that will result in inline code blocks (within a <UL>).

I think the better approach is to push forward the CSS updates to be inclusive of the command output as well as code blocks. if you need help with this I can make a PR for that. (and we should add snapshots for this as well)

@habdelra
Copy link
Contributor

habdelra commented Feb 24, 2025

My bad, I jumped the gun on that and rejected this before I was able to see the output. codeblocks look ok:

image

but I'm updating the PR to also snapshot the code blocks

@burieberry burieberry merged commit 06d59c9 into main Feb 25, 2025
48 checks passed
@burieberry burieberry deleted the cs-8037-fix-broken-assistant-code-view branch April 2, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants