Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some matrix helpers / test assertions #2210

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Clean up some matrix helpers / test assertions #2210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions packages/matrix/helpers/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,8 @@ export async function reloadAndOpenAiAssistant(page: Page) {

export async function openAiAssistant(page: Page) {
await page.locator('[data-test-open-ai-assistant]').click();
await page.waitForFunction(() =>
document.querySelector('[data-test-close-ai-assistant]'),
);

await page.waitForFunction(() =>
document.querySelector('[data-test-room]')?.getAttribute('data-test-room'),
); // Opening the AI assistant either opens last room or creates one - wait for it to settle
await expect(page.locator('[data-test-close-ai-assistant]')).toHaveCount(1);
await expect(page.locator('[data-test-room]')).toHaveCount(1);
}

export async function createRealm(
Expand Down Expand Up @@ -265,9 +260,7 @@ export async function login(
) {
await openRoot(page, opts?.url);

await page.waitForFunction(() =>
document.querySelector('[data-test-username-field]'),
);
await expect(page.locator('[data-test-username-field]')).toBeEditable();
await page.locator('[data-test-username-field]').fill(username);
await page.locator('[data-test-password-field]').fill(password);
await page.locator('[data-test-login-btn]').click();
Expand Down
5 changes: 1 addition & 4 deletions packages/matrix/tests/room-creation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,7 @@ test.describe('Room creation', () => {

// Open assistant without waiting for [data-test-room] which won’t show on a new account
await page.locator('[data-test-open-ai-assistant]').click();
await page.waitForFunction(() =>
document.querySelector('[data-test-close-ai-assistant]'),
);

await expect(page.locator(`[data-test-close-ai-assistant]`)).toHaveCount(1);
await expect(page.locator(`[data-test-chat-title]`)).not.toHaveText(
'New AI Assistant Chat',
);
Expand Down