Fix pre-rendered spec card icon #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FadhlanR
commented
Mar 10, 2025
packages/base/spec.gts
Outdated
|
|
||
| export type SpecType = 'card' | 'field' | 'app' | 'skill'; | ||
|
|
||
| class SpecTypeField extends StringField { | ||
| static displayName = 'Spec Type'; | ||
| } | ||
|
|
||
| class Isolated extends Component<typeof Spec> { | ||
| @tracked icon: CardOrFieldTypeIcon | undefined; |
There was a problem hiding this comment.
I had to move out the Isolated, Fitted, and Edit views to satisfy the type check since I use @tracked.
Host Test Results 1 files ± 0 1 suites ±0 26m 14s ⏱️ + 1m 5s Results for commit 13f6838. ± Comparison against base commit 40ad332. This pull request removes 803 and adds 827 tests. Note that renamed tests count towards both.This pull request removes 2 skipped tests and adds 3 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tintinthong
approved these changes
Mar 10, 2025
lukemelia
requested changes
Mar 10, 2025
packages/base/spec.gts
Outdated
| this.loadCardIcon.perform(); | ||
| } | ||
|
|
||
| private loadCardIcon = restartableTask(async () => { |
There was a problem hiding this comment.
Since this is only ever called once in the constructor, there is no reason for it to be a restartableTask. It should just be a task.
There was a problem hiding this comment.
On that topic, perhaps this task should be executed again if the ref changes?
There was a problem hiding this comment.
I used resource instead, so it will be reload if the value of ref is updated.
packages/base/spec.gts
Outdated
| this.loadCardIcon.perform(); | ||
| } | ||
|
|
||
| private loadCardIcon = restartableTask(async () => { |
packages/base/spec.gts
Outdated
| this.loadCardIcon.perform(); | ||
| } | ||
|
|
||
| private loadCardIcon = restartableTask(async () => { |
FadhlanR
force-pushed
the
cs-8118-fix-prerendered-spec-card-icon
branch
from
da8eb7e to
bde2119
Compare
lukemelia
approved these changes
Mar 13, 2025
burieberry
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal solution to fix the bug where the pre-rendered spec card displays a loading state as its icon. In this PR, we use the spec card's own card type icon as the icon for the pre-rendered spec card.
Screen.Recording.2025-03-10.at.12.11.25.mov