Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sync is throttled and not running a tight loop #2265

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

IanCal
Copy link
Contributor

@IanCal IanCal commented Mar 11, 2025

Fixes an issue with the throttled sync call blocking other requests internally and hitting a tight loop.

@IanCal IanCal requested review from lukemelia and habdelra March 11, 2025 14:57
Copy link

github-actions bot commented Mar 11, 2025

Host Test Results

       1 files  ±    0         1 suites  ±0   52m 10s ⏱️ + 26m 59s
   803 tests  -     1     800 ✔️  -     2  2 💤 ±0  0 ±0  1 🔥 +1 
1 616 runs  +808  1 610 ✔️ +804  4 💤 +2  1 +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit 4d99056. ± Comparison against base commit 137083c.

This pull request removes 121 and adds 120 tests. Note that renamed tests count towards both.
Chrome 134.0 ‑ Acceptance | Commands tests > suspending global error hook: a command that errors when executing allows retry
Chrome 134.0 ‑ Acceptance | Commands tests: OpenAiAssistantRoomCommand opens the AI assistant room
Chrome 134.0 ‑ Acceptance | Commands tests: a command added from a skill can be executed when clicked on
Chrome 134.0 ‑ Acceptance | Commands tests: a command executed via the AI Assistant shows the result as an embedded card
Chrome 134.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand with autoExecute flag is automatically executed by the bot, panel closed
Chrome 134.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand with autoExecute flag is automatically executed by the bot, panel open
Chrome 134.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand without autoExecute flag is not automatically executed by the bot
Chrome 134.0 ‑ Acceptance | Commands tests: a scripted command can create a card, update it and show it
Chrome 134.0 ‑ Acceptance | Commands tests: command returns serialized result in room message
Chrome 134.0 ‑ Acceptance | Commands tests: multiple commands can be requested in a single aibot message
…
Chrome 133.0 ‑ Acceptance | Commands tests > suspending global error hook: a command that errors when executing allows retry
Chrome 133.0 ‑ Acceptance | Commands tests: OpenAiAssistantRoomCommand opens the AI assistant room
Chrome 133.0 ‑ Acceptance | Commands tests: a command added from a skill can be executed when clicked on
Chrome 133.0 ‑ Acceptance | Commands tests: a command executed via the AI Assistant shows the result as an embedded card
Chrome 133.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand with autoExecute flag is automatically executed by the bot, panel closed
Chrome 133.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand with autoExecute flag is automatically executed by the bot, panel open
Chrome 133.0 ‑ Acceptance | Commands tests: a command sent via SendAiAssistantMessageCommand without autoExecute flag is not automatically executed by the bot
Chrome 133.0 ‑ Acceptance | Commands tests: a scripted command can create a card, update it and show it
Chrome 133.0 ‑ Acceptance | Commands tests: command returns serialized result in room message
Chrome 133.0 ‑ Acceptance | Commands tests: multiple commands can be requested in a single aibot message
…

♻️ This comment has been updated with latest results.

@lukemelia lukemelia merged commit 4213287 into main Mar 11, 2025
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants