Skip to content

Re-render issue when accessing property inside of a getter #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tintinthong
Copy link
Contributor

@tintinthong tintinthong commented Mar 17, 2025

This PR reveals something very simple.

When reactivity forces you to call Box.create, our component will be re-rendered. This is bcos the Box identity is lost entirely and we cannot leverage the stability of componentCache in getBoxComponent

In the example showed, a simple property access within a console.log triggeres this re-render.

@tintinthong tintinthong changed the title Re-render issue inside of getter Re-render issue when accessing property inside of a getter Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

Host Test Results

    1 files  ±  0      1 suites  ±0   25m 40s ⏱️ -49s
768 tests  - 63  747 ✔️  - 80  2 💤  - 1    1 +  1  18 🔥 +17 
772 runs   - 64  733 ✔️  - 98  2 💤  - 1  19 +18  18 🔥 +17 

For more details on these failures and errors, see this check.

Results for commit f73b4da. ± Comparison against base commit ed0c10d.

This pull request removes 64 and adds 1 tests. Note that renamed tests count towards both.
Chrome 134.0 ‑ Integration | Component | RoomMessage: it does not show an error when last streaming chunk is still within reasonable time limit
Chrome 134.0 ‑ Integration | Component | RoomMessage: it escapes html code that is in code tags
Chrome 134.0 ‑ Integration | Component | RoomMessage: it shows an error when AI bot message streaming timeouts
Chrome 134.0 ‑ Integration | card api (Usage of publicAPI actions) > getCards: changing query updates search resource
Chrome 134.0 ‑ Integration | card-editor: can change card format
Chrome 134.0 ‑ Integration | card-editor: can choose a card for a linksTo field that has an existing value
Chrome 134.0 ‑ Integration | card-editor: can choose a card for a linksTo field that has no existing value
Chrome 134.0 ‑ Integration | card-editor: can create a new card to populate a linksTo field
Chrome 134.0 ‑ Integration | card-editor: can create a specialized a new card to populate a linksTo field
Chrome 134.0 ‑ Integration | card-editor: can remove the link for a linksTo field
…
Chrome 134.0 ‑ Global error: Uncaught Error: status: 500 -           . unexpected exception in realm Error: Your filter refers to nonexistent type: import { Author } from "http://test-realm/test/author" at http://localhost:7357/assets/chunk.5879e221b00ab79f27d9.js, line 466341  While executing test: Integration | card api (Usage of publicAPI actions) > getCards: changing query updates search resource 

♻️ This comment has been updated with latest results.

@tintinthong tintinthong force-pushed the sample-issue-rerender branch from 05ce790 to 52a929c Compare March 18, 2025 01:14
@tintinthong tintinthong changed the base branch from cs-8185-refactor-getcard-usage to main March 18, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant