fix navigation issues with spec #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tintinthong
force-pushed
the
fix-first-instance-change-file-2
branch
from
5b9a88b to
c2986af
Compare
tintinthong
changed the base branch from
cs-8185-refactor-getcard-usage
to
main
Host Test Results 1 files ±0 1 suites ±0 27m 45s ⏱️ -17s Results for commit 3129465. ± Comparison against base commit 8e1fed4. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| @onClick={{fn | ||
| this.selectAccordionItem | ||
| 'schema-editor' | ||
| false |
There was a problem hiding this comment.
@tintinthong is this boolean parameter needed?
@action private selectAccordionItem(item: SelectedAccordionItem) {
| this.selectAccordionItem | ||
| 'playground' | ||
| }} | ||
| @isLoadingNewModule={{this.moduleContentsResource.isLoadingNewModule}} |
There was a problem hiding this comment.
This might not be needed
There was a problem hiding this comment.
I do want to keep this so I can show a loading state while changing module and return a default title
packages/host/app/components/operator-mode/code-submode/spec-preview.gts
Outdated
Show resolved
Hide resolved
accordion fix fix lint wrong argument fix test fix test follow up fixes fix lint fix lint fix lint fix lint
tintinthong
force-pushed
the
fix-first-instance-change-file-2
branch
from
fd953b9 to
3129465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that if you change a selection on LHS, it doesn't remain stale (particularly after you have chosen something in the dropdown) See this test
Other changes
As part of this PR there is a digression in auto-save. I do not have a good solution for that and have skipped the test. But, the structure that we want is closer to this. PLS REVIEW THIS INDEPENDENTLY OF THE AUTO_SAVE ISSUE