host: Add clientRequestIds to code mode editor requests #2399
+126
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host Test Results 1 files ±0 1 suites ±0 30m 40s ⏱️ +24s For more details on these errors, see this check. Results for commit 9ff0393. ± Comparison against base commit 2e0a7c2. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
But the card-editing test is failing…???
Was it too LONG?
…-too-much-synchronization-work' into source-clientRequestId-plus-cs-8313-card-resource-still-does-too-much-synchronization-work # Conflicts: # packages/host/app/services/store.ts # packages/host/tests/acceptance/code-submode/card-playground-test.gts
This should be covered by realm events…!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates code mode to include
clientRequestIdinPOSTrequests produced by the editor saving changes. This should prevent data loss such as seen here: