Skeleton catalog app #2404
Skeleton catalog app #2404
Conversation
…f-catalog-to-be-list-of-cards-and-fields
extend cardContainer, but more customize compare to cardContainer, and i want default the height to auto
- extra: change the position of topbar-filter to catalog-content area (mid column)
* add fields title * create app-listing-header & enhance card-listing-container cssvar * create app listing embedded view & instances - create embedded view - create instances related * remove stale
Allow listing to create card inside a particular workspace
* Rename card-listing-container to content-container * improve app-listing-header * create pricing plan & images-videos & example list skeleton * add fields tittle to category & create category instances * craete listing categories & instances * add headerColor
* give a better name for cards-display section * introduce intro blocks and content to card display section * create showcase skeleton
Add blog app to catalog
richardhjtan
force-pushed
the
skeleton-catalog-app
branch
from
94df9d0 to
7528ea2
Compare
richardhjtan
force-pushed
the
skeleton-catalog-app
branch
from
8e08213 to
d7bbd6e
Compare
richardhjtan
force-pushed
the
skeleton-catalog-app
branch
from
d7bbd6e to
6ff39d1
Compare
|
This is marked as "Draft", do you still want us to review it or no? |
yes pls review it @habdelra |
|
@habdelra I drafted it back due to adding some new tests, but there will be no significant changes to that - please feel free to review it. Thanks! |
| @@ -299,7 +299,7 @@ export class Realm { | |||
| this.#dbAdapter = dbAdapter; | |||
|
|
|||
| this.#router = new Router(new URL(url)) | |||
| .post('/', SupportedMimeType.CardJson, this.createCard.bind(this)) | |||
| .post('(/|/.+/)', SupportedMimeType.CardJson, this.createCard.bind(this)) | |||
| .patch( | |||
There was a problem hiding this comment.
@habdelra there is this api change here. It opens the realm to creating card in a directory of their choice. I made this decision bcos I did not think that introducing a new directory api was a good idea since it may encourage empty directories (which we cant delete now)
There was a problem hiding this comment.
This is to support the use-case that we copy examples into a single folder. And not just splate it all over the realm
There was a problem hiding this comment.
I'm ok with this, but let's make sure that you can't escape out of the realm's file system, e.g. ../../../../etc/passwd
There was a problem hiding this comment.
Ticketed this improvement in Linear, which can be easier to review later: https://linear.app/cardstack/issue/CS-8436/improve-file-system-handling-creating-a-card-in-a-directory
| let catalogActions: CatalogActions = { | ||
| create: async (spec: Spec, targetRealm: string) => { | ||
| await here._createFromSpec.perform(spec, targetRealm); | ||
| }, | ||
| copy: async (card: CardDef, targetRealm: string) => { | ||
| return await here._copy.perform(card, targetRealm); | ||
| }, | ||
| copySource: async (fromUrl: string, toUrl: string) => { | ||
| return await here._copySource.perform(fromUrl, toUrl); | ||
| }, | ||
| copyCards: async ( | ||
| cards: CardDef[], | ||
| targetRealm: string, | ||
| directoryName?: string, | ||
| ): Promise<CardDef[]> => { | ||
| return await here._copyCards.perform(cards, targetRealm, directoryName); | ||
| }, | ||
| allRealmsInfo: async () => { | ||
| return await here.realm.allRealmsInfo; | ||
| }, | ||
| }; | ||
| return { ...actions, ...catalogActions }; |
There was a problem hiding this comment.
These are the API additions for interact submode, so listing card can consume these actions in context
Good catch @burieberry , addressed them in latest commit |
Refer to https://linear.app/cardstack/issue/CS-8410/move-skeleton-catalog-app-into-feature-flagged-environment
What is changing
catalog-realm-dev, which under feature flagged environmentcomponentspec typeNotes