Error handling in playground panel #2440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burieberry
force-pushed
the
cs-8414-code-mode-errors
branch
from
e597cda to
4522219
Compare
lukemelia
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
handle indexing errors for playground the same way it's handled for interact mode and code-mode preview -- using cardResource's
cardErrorproperty and displaying last known good state via error metarefactor error processing in store -- added handling for serialization error type
CardError(not sure how often this might happen, but previously came across this when previously there was a bug where playground was trying to create card in realm in which the user did not have permissions in)when deleting a card, remove it from playground local storage if it was saved there