Skip to content

host: Update Monaco modifier #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

host: Update Monaco modifier #2442

merged 2 commits into from
Apr 16, 2025

Conversation

backspace
Copy link
Contributor

This removes an unnecessary conditional and extracts a setup function. It was originally in #2399.

@backspace backspace self-assigned this Apr 16, 2025
Copy link

Host Test Results

  1 files  ± 0    1 suites  ±0   30m 16s ⏱️ + 2m 20s
921 tests +50  915 ✅ +51  6 💤 ±0  0 ❌ ±0 
928 runs  +51  922 ✅ +53  6 💤 ±0  0 ❌  - 1 

Results for commit 92719b7. ± Comparison against base commit a87b83c.

This pull request removes 1 and adds 51 tests. Note that renamed tests count towards both.
Chrome ‑ error
Chrome ‑ Acceptance | Freestyle: smoke check
Chrome ‑ Acceptance | code submode | editor tests > when the user lacks write permissions: the editor is read-only
Chrome ‑ Acceptance | code submode | editor tests: allows fixing broken cards
Chrome ‑ Acceptance | code submode | editor tests: card definition change made in monaco editor is auto-saved
Chrome ‑ Acceptance | code submode | editor tests: card instance JSON displayed in monaco editor
Chrome ‑ Acceptance | code submode | editor tests: card instance change made in card editor is auto-saved
Chrome ‑ Acceptance | code submode | editor tests: card instance change made in monaco editor is auto-saved
Chrome ‑ Acceptance | code submode | editor tests: invalid JSON card instance change made in monaco editor is NOT auto-saved
Chrome ‑ Acceptance | code submode | editor tests: non-card instance change made in monaco editor is auto-saved
Chrome ‑ Acceptance | code submode | editor tests: unsaved changes made in card editor are saved when switching out of code submode
…

@backspace backspace marked this pull request as ready for review April 16, 2025 18:37
@backspace backspace requested a review from a team April 16, 2025 18:37
@backspace backspace merged commit 91524b3 into main Apr 16, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants