Skip to content

Update to serialize unsaved instances using local ID's #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

habdelra
Copy link
Contributor

@habdelra habdelra commented Apr 17, 2025

This PR updates our serialization of cards to serialize unsaved cards using the "lid" property which holds the local ID of the card (this is part of the JSON-API spect). This will facilitate our ability to optimistically create cards and potentially send the server an unsaved link to save.

@habdelra habdelra changed the title Update to serialize unsaved files using local ID's Update to serialize unsaved instances using local ID's Apr 17, 2025
Copy link

github-actions bot commented Apr 17, 2025

Host Test Results

  1 files  ±0    1 suites  ±0   31m 18s ⏱️ +3s
947 tests +2  941 ✅ +2  6 💤 ±0  0 ❌ ±0 
954 runs  +2  948 ✅ +2  6 💤 ±0  0 ❌ ±0 

Results for commit c67e790. ± Comparison against base commit 46ab4b8.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
Chrome ‑ Integration | serialization: throws when serializing a linksTo relationship to an unsaved card
Chrome ‑ Integration | serialization > linksToMany: can serialize a linksToMany relationship with unsaved links
Chrome ‑ Integration | serialization: can serialize a linksTo relationship with an unsaved card
Chrome ‑ Integration | serialization: can serialize an unsaved linksTo relationship that points to itself

♻️ This comment has been updated with latest results.

@habdelra habdelra marked this pull request as ready for review April 17, 2025 15:42
…or-card-api-to-serialize-unsaved-links-using
@habdelra habdelra requested a review from a team April 17, 2025 15:43
@habdelra habdelra merged commit bfcd46c into main Apr 21, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants