introduce eslint-plugin-boxel package, with template-missing-invokable rule #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
changed the title
lukemelia
commented
Apr 22, 2025
lukemelia
commented
Apr 22, 2025
packages/eslint-plugin-boxel/lib/rules/template-missing-invokable.js
Outdated
Show resolved
Hide resolved
lukemelia
commented
Apr 22, 2025
|
What is the gist of this PR? is the idea that this adds a lint rule for missing import statements for commonly used helpers? |
lukemelia
commented
Apr 22, 2025
lukemelia
commented
Apr 22, 2025
Correct, with auto-fix. We will use this plugin from our new linting endpoint in the next PR to autofix code submitted to the endpoint. And then we will use that endpoint to autofix AI-modified code in the subsequent PR. |
lukemelia
force-pushed
the
eslint-plugin-boxel
branch
from
909db19 to
f40b313
Compare
habdelra
reviewed
Apr 22, 2025
There was a problem hiding this comment.
I notice there are a bunch of auto generated files that we have in source control. under what circumstances would we need to regenerate these?
There was a problem hiding this comment.
Only when you add a new rule or change the docs for a rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, I will update #2309 to use it