DAQ Automatic Tests

[tbengani]

Send CAN message in DAQ CAN through DCM when car states up/down between HV_EN and RTD. Use 1 byte: 1 bit for start/stop, 7 bits for test_id.

[MerinoSheep]

Request me on this when you feel like it is finished

[MerinoSheep]

I also think you have a build error somewhere double check if all projects build

[tbengani]

Yea I can't seem to build it on my end. I have errors showing up in other places(not DCM), so maybe my configuration is not right.

[MerinoSheep]

you're probably using the wrong compiler. I would double check the confluence page

[MerinoSheep]

Fix the two things i reviewed then I think were good to merge

[tbengani]

For the compiler, I am using GCC arm-none-eabi, so I'm not sure why its not working.

Do I need to make the changes locally and push them back to this PR?

[MerinoSheep]

Yes just make sure to pull El mar, 18 de feb de 2025, 3:04 p. m., Tanish Bengani < ***@***.***> escribió:

…

For the compiler, I am using GCC arm-none-eabi, so I'm not sure why its not working. Do I need to make the changes locally and push them back to this PR? — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AISGQODLDRF4I2IPAQIYLET2QOG3FAVCNFSM6AAAAABXH4SKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWHAZDAMBWHE> . You are receiving this because you commented.Message ID: ***@***.***> [image: tbengani]*tbengani* left a comment (carnegiemellonracing/monorepo#26) <#26 (comment)> For the compiler, I am using GCC arm-none-eabi, so I'm not sure why its not working. Do I need to make the changes locally and push them back to this PR? — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AISGQODLDRF4I2IPAQIYLET2QOG3FAVCNFSM6AAAAABXH4SKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWHAZDAMBWHE> . You are receiving this because you commented.Message ID: ***@***.***>

[MerinoSheep]

once you pull can you delete build folder and build again

[tbengani]

It builds on my computer now.
Isn't this PR already fixed(semicolon + moving srand)? The build was successful. Or are there other things to change.

[MerinoSheep]

The two things that are part of the review

[tbengani]

Wait I'm confused-- what exactly should I fix(and where do I find it)?

[MerinoSheep]

scroll up in the review or ctrl f "review" there are two items

…

On Tue, Feb 18, 2025 at 5:21 PM Tanish Bengani ***@***.***> wrote: Wait I'm confused-- what exactly should I fix(and where do I find it)? — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AISGQOCCCZC324ZDHYYWBZ32QOW53AVCNFSM6AAAAABXH4SKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGA2TCOJRHA> . You are receiving this because you commented.Message ID: ***@***.***> [image: tbengani]*tbengani* left a comment (carnegiemellonracing/monorepo#26) <#26 (comment)> Wait I'm confused-- what exactly should I fix(and where do I find it)? — Reply to this email directly, view it on GitHub <#26 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AISGQOCCCZC324ZDHYYWBZ32QOW53AVCNFSM6AAAAABXH4SKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRXGA2TCOJRHA> . You are receiving this because you commented.Message ID: ***@***.***>

[MerinoSheep]

oh wait my fault they were in preview haha

[tbengani]

ready to merge