-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore[QTM-620]: EvalutationForm #537
Conversation
docs[QTM-619]: Creates EvaluationForm Component
docs[QTM-604] Includes EvaluationForm in Colors, Grid and Typography
docs [QTM-606] - Includes EvaluationForm in Theme, Icon and Breakpoints
docs [QTM-609] Includes EvaluationForm in Link and List
docs [QTM-613] Includes EvaluationForm in Infinite Scroll, Hooks/useMaxWithMediaQuery & Accordion
docs [QTM-615] Includes EvaluationForm in Forms Components
docs: [QTM-625] Includes EvaluationForm in remaining components
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[x] Code review
[x] Doc
@@ -1,3 +1,4 @@ | |||
/* eslint-disable jsx-a11y/control-has-associated-label */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jest was failing the test without it
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 9.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
https://jirasoftware.catho.com.br/browse/QTM-620
Setup
to view the components behavior, run
yarn storybook
Review guide