fix(Button.jsx): Forwarding disabled prop to button component #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alizeleal
added
status:reviewing
alizeleal
approved these changes
Sep 10, 2024
alizeleal
added
status:approved
and removed
status:reviewing
|
🎉 This PR is included in version 10.0.0-beta.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was identified that the disabled prop that is passed to the component was being used only for aesthetic purposes and was not being passed to the button element, thus impacting the accessibility of the component. To test, access the regressive test, select button-disabled and check if the disabled attribute is present in the element through the DOM tree
Review guide