Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subs not in output folder v0.2.122 #28

Closed
mikemonello opened this issue Jun 27, 2024 · 9 comments
Closed

Subs not in output folder v0.2.122 #28

mikemonello opened this issue Jun 27, 2024 · 9 comments

Comments

@mikemonello
Copy link

This version puts the subtitle files in the source folder rather than the output folder, which (I think) might be causing it to hang without giving an error.

@cbusillo
Copy link
Owner

That’s odd, it should have been fixed and has worked for me every time.

@cbusillo
Copy link
Owner

Technically, they are generated in the source but moved to the output folder. That’s a limitation of the pgsrip library I use. It doesn’t have an output folder option. I opened an issue with them. Either way, after the sub stage is finished, they should have been moved to the destination. Can you send screen shots of the settings, output log and folder view? BTW, this is only with mkvs, since they are the source for the pgsrip.

@mikemonello
Copy link
Author

Ahh, OK. I'm trying to get a good file of Titanic 3D, which is on two BDs. I've had trouble merging spatial files without additional processing, which is why I was ripping to MKV, merging, and then converting. I'm running rips off the ISOs now and will try to merge the spatial files without losing anything and see how that goes.

@cbusillo
Copy link
Owner

Use MP4Box, make sure it's the 2.2.1 we installed. Other tools will likely lose the spatial data. 2.4 seems to cause the seeking issue sometimes.

@cbusillo
Copy link
Owner

@mikemonello Do the subs end up in the right place? Were you just reporting that they appeared in the wrong place, but thats part of the design for now? This is the issue I made on the pgs library.

As far as merging two disc movies, I thought long and hard about it, but didn't have a great plan for it.

@kalanihelekunihi
Copy link

MikeMonello: if you ever get the “merged” Titanic 3D steps figured out, I’d personally really like to get those steps.

@cbusillo
Copy link
Owner

@kalanihelekunihi I would encode each separate then use MP4Box 2.2.1 to concat the videos. We use MP4Box to mux the video so it probably wont break the spatial data. 2.2.1 should be installed on your system if you are using my software.

@mikemonello
Copy link
Author

I finally got Titanic properly ripped. Using the current version (0.2.122). The workflow I used was:

  1. Rip both BD3D discs to ISO clones using DVDFab
  2. Rip both ISO files to 3DMKV using MakeMKV, selecting only the English language soundtracks and subtitles, and ensuring both video tracks are selected.
  3. Merge the 3DMKV files using Shutter Encoder, which does not repack or reprocess the files.
  4. Ran the merged MKV through BD_to_AVP, using standard quality options and selecting only "Continue Processing on Error" and "Remove Extra Languages".

All of the errors came from rips where I had selected to "transcode audio" so that's where the issue is.

@cbusillo
Copy link
Owner

Closing the subs issue, since it was already "fixed" by moving after creation. I have an open issue in pgsrip. If they add a destination folder option, I will update bd-to-avp to output directly into the correct folder. Still thinking about your transcoding issue. I believe you have another open issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants