Use role dependencies instead of explicit include_roles
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Role dependencies cannot be platform-specific and `geerlingguy.mac.homebrew` doesn't check its host platform. :(
We cannot otherwise make this conditional on running on macOS only.
florianpiesche
requested review from
emyers-ccdc,
sjackson-ccdc and
ngonzalez-ccdc
|
I've had to re-add the explicit |
emyers-ccdc
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will cause Ansible to de-duplicate rule inclusion, speeding up provisioning time and reducing the amount of interference through repeat provisioning.