Step by step docs #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriluos
reviewed
Oct 31, 2024
README.md
Outdated
Comment on lines
172
to
176
| After making any changes to these files, restart the stack using the following config files. | ||
|
|
||
| - docker-compose.yml | ||
| - docker-compose.ssl.yml | ||
| - Any other docker compose files which you have customised |
There was a problem hiding this comment.
This could also include the MMHUB file.
I think this section repeats the one above that explains which files should be included in your compose file. Could we reference that section instead, instructing to then append any customised compose files?
There was a problem hiding this comment.
I've updated it to say "restart the stack as described above, adding in any docker compose files which you have customised".
README.md
Outdated
| If the WebCSD server is run without configuring SSL a built-in self-signed certificate will be used. | ||
| This is not recommended as it is insecure. | ||
|
|
||
| ## Installation | ||
| ### WebCSD Test Installation |
There was a problem hiding this comment.
Calling this a test installation makes it sound like it's separate to the actual installation. Could this be called WebCSD Basic Installation, or something similar, instead?
There was a problem hiding this comment.
Changed to "WebCSD Basic Installation".
chriluos
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.