Skip to content

Commit

Permalink
[CDAP-21096] Make appfabric service backward compatible after splitti…
Browse files Browse the repository at this point in the history
…ng into processor
  • Loading branch information
vsethi09 committed Feb 7, 2025
1 parent d80f037 commit 6ed3827
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
8 changes: 8 additions & 0 deletions api/v1alpha1/cdapmaster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ type CDAPScalableStatefulServiceSpec struct {
// AppFabricSpec defines the specification for the AppFabric service.
type AppFabricSpec struct {
CDAPScalableServiceSpec `json:",inline"`
// StorageSize is specification for the persistent volume size used by the service.
// Note: This is added for backward compatibility where Appfabric runs as CDAP stateful service.
// This field can be set to nil if appfabric is run as CDAP scalable service.
StorageSize *string `json:"storageSize,omitempty"`
// StorageClassName is the name of the StorageClass for the persistent volume used by the service.
// Note: This is added for backward compatibility where Appfabric runs as CDAP stateful service.
// This field can be set to nil if appfabric is run as CDAP scalable service.
StorageClassName *string `json:"storageClassName,omitempty"`
}

// AppFabricProcessorSpec defines the specification for the AppFabric Processor service.
Expand Down
10 changes: 10 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions config/crd/bases/cdap.cdap.io_cdapmasters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4411,6 +4411,14 @@ spec:
description: ServiceAccountName overrides the service account
for the service pods.
type: string
storageClassName:
description: StorageClassName is the name of the StorageClass
for the persistent volume used by the service.
type: string
storageSize:
description: StorageSize is specification for the persistent volume
size used by the service.
type: string
type: object
appFabricProcessor:
description: AppFabricProcessor is specification for the CDAP app-fabric
Expand Down

0 comments on commit 6ed3827

Please sign in to comment.