Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jodit w/ npm auto-update #1739

Merged
merged 24 commits into from
Mar 6, 2024
Merged

Update jodit w/ npm auto-update #1739

merged 24 commits into from
Mar 6, 2024

Conversation

xdan
Copy link
Contributor

@xdan xdan commented Jan 8, 2024

@xdan
Copy link
Contributor Author

xdan commented Jan 10, 2024

Hi, @KazmaZhang can you check it?

@xdan
Copy link
Contributor Author

xdan commented Jan 11, 2024

@MattIPv4 Hi, can you check it?

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 I'm not sure this is really the config you want. When you specify a basePath, we pull assets out of that folder into the root. So if you have es2021/index.js and es2018/index.js, then we're going to randomly pick one of those to be index.js essentially.

If you want to include multiple directories like this, you probably just want a single entry with an empty basePath.

@xdan
Copy link
Contributor Author

xdan commented Jan 15, 2024

@MattIPv4 Hi, again. I already tried an empty basePath, it crashes https://github.com/cdnjs/packages/actions/runs/7525599621/job/20482198820?pr=1739
Maybe because there are a lot of files. Maybe I need to reduce the number of files?

@MattIPv4
Copy link
Member

MattIPv4 commented Jan 15, 2024

Yes, there does seem to be a very very large number of files being matched due to the globstar in the config.

Could I suggest setting the basePath to es5 (or es2015/es2018/es2021) and just including those files, as there is far less of them and they should work in all browsers? Your esm code includes a mix of relative and package imports, so I'm not sure that'd even work in a browser.

@xdan
Copy link
Contributor Author

xdan commented Jan 17, 2024

@MattIPv4 Hi again, I fixed it.

@xdan
Copy link
Contributor Author

xdan commented Jan 29, 2024

@MattIPv4 Would you mind taking a look at this, please?

@MattIPv4 MattIPv4 changed the title Update jodit.json Update jodit w/ npm auto-update Jan 30, 2024
Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4 MattIPv4 merged commit 7c1b2fd into cdnjs:master Mar 6, 2024
1 check passed
@xdan
Copy link
Contributor Author

xdan commented Apr 7, 2024

@MattIPv4 Hi, when will this fix be rolled out? I still don't have the files https://cdnjs.com/libraries/jodit

@MattIPv4
Copy link
Member

MattIPv4 commented Apr 7, 2024

No new version has been released since this was merged; https://github.com/cdnjs/logs/tree/prod/packages/j/jodit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants