-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jodit w/ npm auto-update #1739
Conversation
Hi, @KazmaZhang can you check it? |
@MattIPv4 Hi, can you check it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 I'm not sure this is really the config you want. When you specify a basePath
, we pull assets out of that folder into the root. So if you have es2021/index.js
and es2018/index.js
, then we're going to randomly pick one of those to be index.js
essentially.
If you want to include multiple directories like this, you probably just want a single entry with an empty basePath
.
@MattIPv4 Hi, again. I already tried an empty basePath, it crashes https://github.com/cdnjs/packages/actions/runs/7525599621/job/20482198820?pr=1739 |
Yes, there does seem to be a very very large number of files being matched due to the globstar in the config. Could I suggest setting the basePath to es5 (or es2015/es2018/es2021) and just including those files, as there is far less of them and they should work in all browsers? Your esm code includes a mix of relative and package imports, so I'm not sure that'd even work in a browser. |
@MattIPv4 Hi again, I fixed it. |
@MattIPv4 Would you mind taking a look at this, please? |
Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MattIPv4 Hi, when will this fix be rolled out? I still don't have the files https://cdnjs.com/libraries/jodit |
No new version has been released since this was merged; https://github.com/cdnjs/logs/tree/prod/packages/j/jodit |
Hi, I have new build structure https://www.npmjs.com/package/jodit?activeTab=code