intra/tcp.go: don't create TCP endpoint before Dial() returns

[Lanius-collaris]

@ignoramous
I wonder if this change breaks anything.

[ignoramous]

dnsOverride in L190 assumes a connected gconn.

On the diff, before return err, the egressing conn, pc, must be clos()d.

[Lanius-collaris]

Why does firestack c646f0c close the TCP connection if the ANSWER SECTION of a DNS response is empty? ( e.g. dig +tcp github.com AAAA )

[ignoramous]

Why does firestack c646f0c close the TCP connection if the ANSWER SECTION of a DNS response is empty? ( e.g. dig +tcp github.com AAAA )

Strange. I'll take a look. Does it happen for all transport types in addition to DNS53 (DoH/ODoH, DoT, DNSCrypt)?

[Lanius-collaris]

Why does firestack c646f0c close the TCP connection if the ANSWER SECTION of a DNS response is empty? ( e.g. dig +tcp github.com AAAA )

Strange. I'll take a look. Does it happen for all transport types in addition to DNS53 (DoH/ODoH, DoT, DNSCrypt)?

Log:

W transport.go:712: dns: fwd: Preferred is missing; using default
W goos.go:159: dns53: goosr: err(lookup github.com. on 192.168.122.1:53: no such host) / size(0)
E transport.go:847: async.go:58>>asm_amd64.s:1700>>???dns: tcp: for -1 err! tot: 1, t: 240ms, lookup github.com. on 192.168.122.1:53: no such host

Firestack called net.Resolver.LookupNetIP() instead of sending the original DNS query?

[ignoramous]

Firestack called net.Resolver.LookupNetIP() instead of sending the original DNS query?

Default DNS isn't set (cf bootstrap.go) isn't set, and so it uses goos.go which simply delegates it to Go's built-in resolver (if in Loopback mode) or OS-preferred resolver (via libc, I imagine).

[Lanius-collaris]

Firestack called net.Resolver.LookupNetIP() instead of sending the original DNS query?

Default DNS isn't set (cf bootstrap.go) isn't set, and so it uses goos.go which simply delegates it to Go's built-in resolver (if in Loopback mode) or OS-preferred resolver (via libc, I imagine).

Oh, I hardcoded TIDCSV "Preferred" in my small CLI but forgot to add a DNS transport with ID "Preferred".

[ignoramous]

Oh, I hardcoded TIDCSV "Preferred" in my small CLI but forgot to add a DNS transport with ID "Preferred".

The firestack API isn't the greatest :(

[ignoramous]

We have been bug bashing connectivity issues (mostly the DNS, retrier.go, and connpool.go, Proxy bits). We are almost done with the critical/big ones. I intend to merge this PR once we are done with it all.