Vulkan: Protect against uniform var ringbuffer overflow #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goeiecool9999
changed the title
goeiecool9999
force-pushed
the
syncuniform
branch
from
048b3d4 to
3e8456e
Compare
Exzap
reviewed
Oct 13, 2024
|
All ok during testing. You can merge this when ready. Thanks for looking into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the uniform ringbuffer is full and if it is wait for commands to finish.
In my testing Breath of the Wild can run correctly with a ring buffer as small as 10 KB (with terrible performance obviously). When using a buffer smaller than that debug builds can detect corruption and assert/log. Although it's definitely impossible above a certain ringbuffer size.