Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript + JSX #53

Closed
theduke opened this issue Jun 16, 2017 · 2 comments
Closed

Typescript + JSX #53

theduke opened this issue Jun 16, 2017 · 2 comments

Comments

@theduke
Copy link

theduke commented Jun 16, 2017

Typescript files that contain JSX have the .tsx extension.

Those files are currently not recognized by loc.
@cgag
Copy link
Owner

cgag commented Sep 23, 2017

This appears to be in master actually. I may have accepted a PR after this issue was opened. However, I see that the language is labeled as Tsx. Do you think that makes sense or do you think it should be lumped under typescript?

@theduke
Copy link
Author

theduke commented Sep 23, 2017

I think it makes sense as a separate language, but it should be labeled "Typescript JSX" rather than Tsx.

Just Tsx could be quite confusing.

@cgag cgag closed this as completed Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theduke @cgag