weak ref to parent for auto release

chaimPaneth · chaimPaneth · commit f435e50da762 · 2022-04-24T14:34:43.000+03:00
diff --git a/ios/RNJWPlayer/RNJWPlayerViewController.h b/ios/RNJWPlayer/RNJWPlayerViewController.h
@@ -22,7 +22,7 @@
 
 @interface RNJWPlayerViewController : JWPlayerObjCViewController <JWPlayerDelegate, JWPlayerStateDelegate, JWAdDelegate, JWCastDelegate, JWAVDelegate, JWPlayerViewDelegate, JWPlayerViewControllerDelegate, JWDRMContentKeyDataSource, AVPictureInPictureControllerDelegate>
 
-@property(nonatomic, strong)RNJWPlayerView *parentView;
+@property(nonatomic, weak)RNJWPlayerView *parentView;
 
 -(void)setDelegates;
 
diff --git a/ios/RNJWPlayer/RNJWPlayerViewController.m b/ios/RNJWPlayer/RNJWPlayerViewController.m
@@ -20,23 +20,6 @@ -(void)setDelegates
     self.player.contentKeyDataSource = self;
 }
 
-- (void)removeFromParentViewController
-{
-    [self reset];
-}
-
-- (void)dealloc
-{
-    [self reset];
-}
-
--(void)reset
-{
-    [self.player stop];
-    [self.view removeFromSuperview];
-    [self willMoveToParentViewController:nil];
-}
-
 #pragma mark - JWPlayer Delegate
 
 - (void)jwplayerIsReady:(id<JWPlayer>)player
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-jw-media-player",
-  "version": "0.2.13",
+  "version": "0.2.14",
   "description": "React-native Android/iOS plugin for JWPlayer SDK (https://www.jwplayer.com/)",
   "main": "index.js",
   "types": "./index.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-native-jw-media-player",`
`3`		`- "version": "0.2.13",`
	`3`	`+ "version": "0.2.14",`
`4`	`4`	`"description": "React-native Android/iOS plugin for JWPlayer SDK (https://www.jwplayer.com/)",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"types": "./index.d.ts",`