Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deep Dive to github_submit_pull_request.md #69

Open
chalmerlowe opened this issue May 8, 2017 · 0 comments
Open

Add Deep Dive to github_submit_pull_request.md #69

chalmerlowe opened this issue May 8, 2017 · 0 comments

Comments

@chalmerlowe
Copy link
Owner

The Deep Dive section of github_submit_pull_request.md is currently empty.

Some ideas for content include:

  • why to do a pull req from a given branch versus master
  • formatting of pull req messages
  • the importance of trying to do a fetch/pull prior to submitting your pull request so that your PR is as close to clean and merge-able as possible.
  • etc
@chalmerlowe chalmerlowe added this to the 2017 Pycon milestone May 8, 2017
@chalmerlowe chalmerlowe modified the milestones: 2017 Pycon, pycon 2019 Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant