Improve dockerization #2947
Closed
Improve dockerization #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when docker-compose command is run Signed-off-by: Mbaoma <mmaryraphaella@gmail.com>
…when docker-compose command is run Signed-off-by: Mbaoma <mmaryraphaella@gmail.com>
…when docker-compose command is run Signed-off-by: Mbaoma <mmaryraphaella@gmail.com>
…when docker-compose command is run Signed-off-by: Mbaoma <mmaryraphaella@gmail.com>
|
This looks pretty good to me for the most part - however, it looks like the dependency scripts ( |
Signed-off-by: Mbaoma <mmaryraphaella@gmail.com>
Merge branch 'main' of https://github.com/chaoss/augur into improve-dockerization
|
@GregSutcliffe Thank you for catching that! Yes, that accounts for the speedup, as those scripts are typically resource-intensive. However, upon review, I ran the installation scripts in the |
Signed-off-by: Mary Mbaoma <mmaryraphaella@gmail.com>
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docker-compose up --buildcommand is run.This PR fixes #
My pull request reduced the duration of the Run the Build job in the pipeline from 6 minutes and 15 seconds to 2 minutes and 8 seconds.
Notes for Reviewers
Signed commits