Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.81.0 #2988

Merged
merged 27 commits into from
Feb 12, 2025
Merged

Release 0.81.0 #2988

merged 27 commits into from
Feb 12, 2025

Conversation

sgoggins
Copy link
Member

Description

  • Key rotator improvements
  • API Key checking command line function added
  • Message Reviews for PRs speed up

ABrain7710 and others added 25 commits September 1, 2023 20:03
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Andrew Brain <andrewbrain2019@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
- Add multiprocessing tests for publisher and client interfaces
- Add platform and key list commands to publisher API
- Add wait (IE: ACK) command to publisher API
- Add more verbose logging
- Remove redundant requests from expiration process
- Update and expand documentation

Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
Signed-off-by: Ulincsys <ulincsys@gmail.com>
…ction

Speed up pr review comment recollection
Fix github event recollection syntax errors
Use key manager merger into DEV
Add command to get github api key statuses
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pylint

tests/key_manager.py|24 col 16| W0621: Redefining name 'platform' from outer scope (line 62) (redefined-outer-name)
tests/key_manager.py|28 col 4| W0621: Redefining name 'logger' from outer scope (line 69) (redefined-outer-name)
tests/key_manager.py|32 col 4| W0621: Redefining name 'key' from outer scope (line 63) (redefined-outer-name)
tests/key_manager.py|4| W0611: Unused current_process imported from multiprocessing (unused-import)
tests/key_manager.py|5| W0611: Unused PIPE imported from subprocess (unused-import)

@@ -27,6 +29,7 @@
from augur.application.cli import test_connection, test_db_connection, with_database, DatabaseContext
import sqlalchemy as s

from keyman.KeyClient import KeyClient, KeyPublisher

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused KeyClient imported from keyman.KeyClient (unused-import)

@@ -25,6 +27,8 @@
from augur.application.cli import test_connection, test_db_connection, with_database, DatabaseContext
from augur.application.cli._cli_util import _broadcast_signal_to_processes, raise_open_file_limit, clear_redis_caches, clear_rabbitmq_messages

from keyman.KeyClient import KeyClient, KeyPublisher

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused KeyClient imported from keyman.KeyClient (unused-import)

@@ -3,37 +3,47 @@
import sqlalchemy as s

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused sqlalchemy imported as s (unused-import)


from augur.tasks.init.celery_app import celery_app as celery
from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask
from augur.application.db.data_parse import *
from augur.tasks.github.util.github_data_access import GithubDataAccess, UrlNotFoundException
from augur.tasks.github.util.github_random_key_auth import GithubRandomKeyAuth
from augur.tasks.github.util.github_task_session import GithubTaskManifest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused GithubTaskManifest imported from augur.tasks.github.util.github_task_session (unused-import)

from augur.tasks.github.util.util import get_owner_repo
from augur.tasks.util.worker_util import remove_duplicate_dicts
from augur.application.db.models import PullRequestEvent, IssueEvent, Contributor, CollectionStatus
from augur.application.db.lib import get_repo_by_repo_git, bulk_insert_dicts, get_issues_by_repo_id, get_pull_requests_by_repo_id, update_issue_closed_cntrbs_by_repo_id, get_session, get_engine
from augur.application.db.models import PullRequestEvent, IssueEvent, Contributor, Repo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused Repo imported from augur.application.db.models (unused-import)

listening for, just check against each
channel that we have actions prepared for.
"""
if channel == self.ANNOUNCE:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1101: Instance of 'KeyOrchestrator' has no 'ANNOUNCE' member (no-member)

"""
if channel == self.ANNOUNCE:
if "requester_id" in request:
stdout = f"{self.ANNOUNCE}-{request['requester_id']}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1101: Instance of 'KeyOrchestrator' has no 'ANNOUNCE' member (no-member)

conn.publish(stdout, "")
self.logger.info(f"ACK; for: {request['requester_id']}")
elif request["type"] == "LIST_PLATFORMS":
platforms = [ p for p in self.fresh_keys.keys() ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)

self.logger.exception("Error during ANNOUNCE")
continue

elif channel == self.REQUEST:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1101: Instance of 'KeyOrchestrator' has no 'REQUEST' member (no-member)


elif channel == self.REQUEST:
self.refresh_keys()
stdout = f"{self.REQUEST}-{request['requester_id']}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1101: Instance of 'KeyOrchestrator' has no 'REQUEST' member (no-member)

Copy link
Member Author

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

]
}

def mp_consumer(platform):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'platform' from outer scope (line 62) (redefined-outer-name)

if platform not in keys:
raise ValueError(f"Platform not valid for testing keys dict: {platform}")

logger = AugurLogger(f"Keyman_test_consumer").get_logger()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'logger' from outer scope (line 69) (redefined-outer-name)

logger.setLevel(1)
client = KeyClient(platform, logger)

key = client.request()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0621: Redefining name 'key' from outer scope (line 63) (redefined-outer-name)

from keyman.KeyClient import KeyClient, KeyPublisher
from augur.application.logs import AugurLogger

from multiprocessing import Process, current_process

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused current_process imported from multiprocessing (unused-import)

from augur.application.logs import AugurLogger

from multiprocessing import Process, current_process
from subprocess import Popen, PIPE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused PIPE imported from subprocess (unused-import)

Signed-off-by: Sean P. Goggins <s@goggins.com>
@sgoggins sgoggins changed the title Release 0.80.2 Release 0.81.0 Feb 12, 2025
@sgoggins sgoggins added deployed version Live problems with deployed versions documentation Updates documentation database Related to Augur's unifed data model bug-fix Fixes a bug dependencies Pull requests that update a dependency file labels Feb 12, 2025
@sgoggins sgoggins merged commit 455b02a into main Feb 12, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fixes a bug database Related to Augur's unifed data model dependencies Pull requests that update a dependency file deployed version Live problems with deployed versions documentation Updates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants