Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key orchestrator missing in Docker build #2996

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

Ulincsys
Copy link
Contributor

Description

  • Copy keyman directory in Dockerfile
  • Update graphical dockerfile to reflect the current build process

This PR fixes #2994

Signed commits

  • Yes, I signed my commits.

- Copy keyman directory in Dockerfile
- Update graphical dockerfile to reflect the current build process

Signed-off-by: Ulincsys <ulincsys@gmail.com>
@sgoggins
Copy link
Member

@Ulincsys : Is there a reason this is still in draft mode? Do we want @GregSutcliffe to test this branch on his docker config?

@Ulincsys
Copy link
Contributor Author

I'm not currently capable of running the docker build, ideally we would need somebody to test it before we push it to the main branch.

@sgoggins
Copy link
Member

OK. That makes sense. We will see if @GregSutcliffe has time and is comfortable doing that ... otherwise I will set out to test it in the morning.

@GregSutcliffe
Copy link
Collaborator

I already tried just doing a COPY in my environment yesterday, and it didn't fix the issue I'm afraid.

Signed-off-by: Ulincsys <ulincsys@gmail.com>
@Ulincsys
Copy link
Contributor Author

Hi @GregSutcliffe

I was able to (eventually) get Docker working on my end.

I found that the version of Python we're using to run the Docker build does not seem able to import from a module which does not contain an __init__.py. We tested this on a few different versions of Python on bare-metal, and none of them complained about it! After adding that, I was able to run collection via Docker compose from a clean environment, and verified that the key orchestrator was running properly.
image

Please let us know if you still have issues with the build, but otherwise I think this is probably good to patch into main.

@Ulincsys Ulincsys marked this pull request as ready for review February 14, 2025 09:51
@sgoggins sgoggins merged commit c6c86ed into main Feb 14, 2025
10 checks passed
@Ulincsys Ulincsys deleted the keyman-docker-hotfix branch February 14, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running release 0.81.0 in Docker
3 participants