Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging and logical improvements for test_connection decorator #2999

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Logging and logical improvements for test_connection decorator #2999

merged 4 commits into from
Feb 17, 2025

Conversation

Ulincsys
Copy link
Contributor

Description

  • Print full tracebacks for non-timeout exceptions during network connectivity test
  • Pass secondary exceptions (from execution target) transparently
  • Use multiline string for error message printing

Signed commits

  • Yes, I signed my commits.

@Ulincsys
Show tracebacks for network exceptions
46bf034 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
@Ulincsys
Fix incorrect usage of format_exc
1d9583d 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
@Ulincsys
Have decorator pass secondary exceptions transparently
53c3c14 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
@Ulincsys
Logical fixes and general improvements
6954f9c 
- Fix logical issue with try block
- Use multiline string for logging

Signed-off-by: Ulincsys <ulincsys@gmail.com>
sgoggins
sgoggins approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Looks improved.

@sgoggins sgoggins merged commit d8f784a into main Feb 17, 2025
10 checks passed
@Ulincsys Ulincsys deleted the improve_nettest_logging_hotfix branch February 17, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

@ABrain7710 ABrain7710 Awaiting requested review from ABrain7710

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ulincsys @sgoggins