Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip whitespace from keys while loading #3000

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Strip whitespace from keys while loading #3000

merged 1 commit into from
Feb 17, 2025

Conversation

Ulincsys
Copy link
Contributor

Description

  • Fixes a crash that occurs when using HTTPX with API keys that have trailing whitespace

This PR fixes #2998

Signed commits

  • Yes, I signed my commits.

@Ulincsys
Strip whitespace from keys while loading
641f72f 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
sgoggins
sgoggins approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sgoggins sgoggins merged commit 7d58dae into main Feb 17, 2025
10 checks passed
@Ulincsys Ulincsys deleted the fix_protocol_exception_hotfix branch February 17, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

@ABrain7710 ABrain7710 Awaiting requested review from ABrain7710

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New key management hard-crashes on a bad key
2 participants
@Ulincsys @sgoggins