Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate new things for key rotation #3002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sgoggins
Copy link
Member

Description

  • key rotation improvements

Signed-off-by: Sean P. Goggins <s@goggins.com>
@sgoggins sgoggins added the bug-fix Fixes a bug label Feb 17, 2025
@@ -34,7 +34,39 @@ def new_func(ctx, *args, **kwargs):
Consider setting http_proxy variables for limited access installations.")
sys.exit(-1)

return update_wrapper(new_func, function_internet_connection)
return update_wrapper(new_func, function_internet_connection) """

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0001: Parsing failed: 'unexpected character after line continuation character (augur.application.cli.init, line 38)' (syntax-error)

import functools
import click

def has_internet(host="8.8.8.8", port=53, timeout=3):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important part, which changes what we check from a site URL that may have some volatility from time to time to a DNS Nameserver that has the highest uptime requirements of anything on the internet.

Signed-off-by: Sean P. Goggins <s@goggins.com>
retries = 0
while retries < max_retries:
try:
bulk_insert_dicts(contributors_batch, Contributor, ["cntrb_id"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E1120: No value for argument 'natural_keys' in function call (no-value-for-parameter)

import random
from sqlalchemy.exc import OperationalError
from psycopg2.errors import DeadlockDetected
from sqlalchemy.orm import sessionmaker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0611: Unused sessionmaker imported from sqlalchemy.orm (unused-import)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant