Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate new things for key rotation #3002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions augur/application/cli/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from sqlalchemy.exc import OperationalError


def test_connection(function_internet_connection):
""" def test_connection(function_internet_connection):
@click.pass_context
def new_func(ctx, *args, **kwargs):
usage = re.search(r"Usage:\s(.*)\s\[OPTIONS\]", str(ctx.get_usage())).groups()[0]
Expand All @@ -34,7 +34,39 @@ def new_func(ctx, *args, **kwargs):
Consider setting http_proxy variables for limited access installations.")
sys.exit(-1)

return update_wrapper(new_func, function_internet_connection)
return update_wrapper(new_func, function_internet_connection) """

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
E0001: Parsing failed: 'unexpected character after line continuation character (augur.application.cli.init, line 38)' (syntax-error)

import socket
import sys
import functools
import click

def has_internet(host="8.8.8.8", port=53, timeout=3):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the important part, which changes what we check from a site URL that may have some volatility from time to time to a DNS Nameserver that has the highest uptime requirements of anything on the internet.

"""Check internet connectivity by attempting a socket connection to a public DNS."""
try:
socket.setdefaulttimeout(timeout)
socket.create_connection((host, port))
return True
except (socket.timeout, socket.gaierror, socket.error):
return False

def test_connection(func):
"""Decorator to check internet before executing a function."""
@functools.wraps(func)
@click.pass_context
def wrapper(ctx, *args, **kwargs):
if not has_internet():
usage = ctx.get_usage().strip()
print(f"\n\n{usage}\nCommand setup failed.\n"
"You are not connected to the internet.\n"
"Please connect to proceed.\n"
"Consider setting http_proxy variables if on a restricted network.")
sys.exit(-1)
return ctx.invoke(func, *args, **kwargs)

return wrapper

### end modification

def test_db_connection(function_db_connection):
@click.pass_context
Expand Down
Loading