Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison with NoneType logical error #3009

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Fix comparison with NoneType logical error #3009

merged 2 commits into from
Feb 22, 2025

Conversation

Ulincsys
Copy link
Contributor

Description

  • Fix a logical error where a task might try to subtract from NoneType due to a NULL database column value

Signed commits

  • Yes, I signed my commits.

@Ulincsys
Fix comparison with NoneType logical error
9a4b866 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
sgoggins
sgoggins previously approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ABrain7710
ABrain7710 reviewed Feb 21, 2025
View reviewed changes
augur/tasks/github/pull_requests/tasks.py Outdated
review_msg_url += f"?since={core_data_last_collected.isoformat()}"
last_collected_date = get_core_data_last_collected(repo_id)

# the full_collection parameter is hardcoded to False, so we must check if there actually is a last_collected date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you see that the full_collection parameter is hardcoded to false?

ABrain7710
ABrain7710 requested changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@ABrain7710 ABrain7710 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue isn't that full collection is always false (it is set to true for newly added repos). The issue is that the task is looking at core_data_last_collected instead of secondary_data_last_collected

@Ulincsys
Secondary task to use get_secondary_data_last_collected
1e417ca 
Signed-off-by: Ulincsys <ulincsys@gmail.com>
sgoggins
sgoggins approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins merged commit a1a9775 into main Feb 22, 2025
10 checks passed
@Ulincsys Ulincsys deleted the last_collected_null_hotfix branch February 22, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoggins sgoggins sgoggins approved these changes

@ABrain7710 ABrain7710 ABrain7710 approved these changes

@IsaacMilarky IsaacMilarky Awaiting requested review from IsaacMilarky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ulincsys @sgoggins @ABrain7710