[backend] refactor docker container to builder pattern #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
This fixes an issue with scc where the latest version requires a golang update to build. This also prevents the same happening to scorecard in future Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
MoralCode
force-pushed
the
backend-docker-builder
branch
from
a6ab270 to
022ac35
Compare
Signed-off-by: Adrian Edwards <adrian@adriancedwards.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors the docker container for the backend to use a "builder container" pattern that attempts to help optimize the amount of disk space required to build the container
This PR contributed towards #3006
As noted in the linked issue, this PR still refactors, but effectively removes the rust build step since there don't seem to be any dependencies written in rust.
Testing
Since im still trying to find ways to optimize the build, I haven't yet run a full instance of augur on my machine
Notes for Reviewers
TODO:
graphicaldockerfile to be based on this main one since they're largely the sameSigned commits