Skip to content

Impossible to escape / in Wait regex #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3v1n0 opened this issue Feb 28, 2025 · 0 comments · May be fixed by #605
Open

Impossible to escape / in Wait regex #592

3v1n0 opened this issue Feb 28, 2025 · 0 comments · May be fixed by #605

Comments

@3v1n0
Copy link

3v1n0 commented Feb 28, 2025

Describe the bug

Using Wait+Screen /foo\\/bar/ or something vhs fails with

22 │ Wait+Screen /foo\\\/bar/
        	            	                  ^^^^^^ Invalid regular expression 'foo\\\': error parsing regexp: trailing backslash at end of expression: ``
        	            	
        	            	 22 │ Wait+Screen /foo\\\/bar/
        	            	                          ^^^^ Invalid command: bar/

Or similar using a single-escape:

22 │ Wait+Screen /foo\/bar/
        	            	                  ^^^^ Invalid regular expression 'foo\': error parsing regexp: trailing backslash at end of expression: ``
        	            	
        	            	 22 │ Wait+Screen /foo\/bar/
        	            	                        ^^^^ Invalid command: bar/

The only way to check it is using \x{2F} instead of /
3v1n0 added a commit to 3v1n0/authd that referenced this issue Mar 3, 2025
@3v1n0
pam/integration-tests/vhs-helpers: Support matching slashes in regexes
7b28df4 
In Type in prompt commands we may include slashes, but VHS doesn't
escape them properly, so we need to replace them manually with their
character-escaped version.

See: charmbracelet/vhs#592
3v1n0 added a commit to 3v1n0/authd that referenced this issue Mar 11, 2025
@3v1n0
pam/integration-tests/vhs-helpers: Support matching slashes in regexes
149baee 
In Type in prompt commands we may include slashes, but VHS doesn't
escape them properly, so we need to replace them manually with their
character-escaped version.

See: charmbracelet/vhs#592
@desertwitch desertwitch linked a pull request Mar 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lexer): handle regex and escaped delimiters desertwitch/vhs
1 participant
@3v1n0