Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When listing cephfs storage-classes, handle exceptions #40

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

addyess
Copy link
Member

@addyess addyess commented Feb 21, 2025

fix: Prevent charm errors when ceph-client relations are setup

Overview

Introduced in #35 , the cephfs storage classes class parameter_list raises ValueError when there is not enough information to build a list of storage classes. There are situations in normal operation of the charm (update-status or charm actions) when this isn't during a purging operation. In those situations, the best the manifest Manipulator can do is return an empty list.

Co-authored-by: Mateo Florido <mateo.florido@canonical.com>
@addyess addyess merged commit fb17f84 into main Feb 21, 2025
7 checks passed
@addyess addyess deleted the akd/cephfs-cleanup-failure branch February 21, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants