Refactor course filtering to use Storyblok language settings (#1456)

* refactor: remove getDisabledCourses function from featureFlag

* refactor: remove disabled courses tests from featureFlag test suite

* refactor: streamline course filtering logic and clean up featureFlag test

* `Refactor StoryblokRelatedContent.tsx: remove unused code and simplify logic`

* `Update StoryblokRelatedContent.tsx to remove and re-add type union members`

---------

Co-authored-by: Kylee Fields <43586156+kyleecodes@users.noreply.github.com>

Author: danielmarv

app/[locale]/courses/page.tsx

@@ -52,16 +52,17 @@ export default async function Page({ params }: { params: Params }) {
 
   const contentLanguagesString = locale === 'en' ? 'default' : locale;
 
-  const courses = coursesStories?.filter(
-    (course: ISbStoryData) => !FeatureFlag.getDisabledCourses().has(course.full_slug),
+  // ✅ NEW logic for filtering courses by Storyblok 'languages' config
+  const courses = coursesStories?.filter((course: ISbStoryData) =>
+    course.content.languages?.includes(contentLanguagesString),
   );
 
   const conversations = conversationsStories?.filter((conversation: ISbStoryData) =>
-    conversation.content.languages.includes(contentLanguagesString),
+    conversation.content.languages?.includes(contentLanguagesString),
   );
 
   const shorts = shortsStories?.filter((short: ISbStoryData) =>
-    short.content.languages.includes(contentLanguagesString),
+    short.content.languages?.includes(contentLanguagesString),
   );
 
   return <CoursesPage courseStories={courses} conversations={conversations} shorts={shorts} />;

components/storyblok/StoryblokRelatedContent.tsx

@@ -48,27 +48,24 @@ export const StoryblokRelatedContent = (props: StoryblokRelatedContentProps) =>
           };
         });
 
-  const disabledCoursesString = process.env.FF_DISABLED_COURSES;
-
   const filteredRelatedContent = useMemo(() => {
     return relatedContent.filter((story) => {
       const localeString = locale === 'en' ? 'default' : locale || 'default';
       const storyAvailableForLocale =
         story.content?.languages?.length > 0
           ? story.content.languages.includes(localeString)
           : true;
-      const storyDisabled = disabledCoursesString?.includes(story.full_slug);
       const storyIncludedForUserPartners =
         story.content?.included_for_partners?.length > 0
           ? userContentPartners.some((partner) =>
               story.content?.included_for_partners?.map((p) => p.toLowerCase()).includes(partner),
             )
           : true;
-      return storyAvailableForLocale && storyIncludedForUserPartners && !storyDisabled;
+      return storyAvailableForLocale && storyIncludedForUserPartners;
     });
-  }, [relatedContent, disabledCoursesString, locale, userContentPartners]);
+  }, [relatedContent, locale, userContentPartners]);
 
-  let items = filteredRelatedContent
+  const items = filteredRelatedContent
     .map((relatedContentItem) => (
       <RelatedContentCard
         key={`related_content_${relatedContentItem.id}`}

lib/featureFlag.test.ts

@@ -1,23 +1,7 @@
 import { expect } from '@jest/globals';
 import { FeatureFlag } from './featureFlag';
 
-const disabledCourse1 = 'fr/courses/healing-from-sexual-trauma/';
-const disabledCourse2 = 'fr/courses/dating-boundaries-and-relationships/';
-
 describe('featureFlag', () => {
-  it('should return disabled courses when environment variable set', () => {
-    process.env.FF_DISABLED_COURSES = [disabledCourse1, disabledCourse2].join(',');
-
-    expect(Array.from(FeatureFlag.getDisabledCourses())).toContain(disabledCourse1);
-    expect(Array.from(FeatureFlag.getDisabledCourses())).toContain(disabledCourse2);
-  });
-
-  it('should return empty array when environment variable not', () => {
-    process.env.FF_DISABLED_COURSES = '';
-
-    expect(FeatureFlag.getDisabledCourses().size).toEqual(0);
-  });
-
   it('should return user research banner value when environment variable set', () => {
     process.env.NEXT_PUBLIC_FF_USER_RESEARCH_BANNER = 'true';
 

lib/featureFlag.ts

@@ -1,13 +1,4 @@
 export namespace FeatureFlag {
-  export const getDisabledCourses: () => Set<string> = () => {
-    const disabledCourses: string[] = [];
-
-    const disabledCoursesString = process.env.FF_DISABLED_COURSES;
-    if (disabledCoursesString) disabledCourses.push(...disabledCoursesString.split(','));
-
-    return new Set<string>(disabledCourses);
-  };
-
   export const isUserResearchBannerEnabled = () => {
     return process.env.NEXT_PUBLIC_FF_USER_RESEARCH_BANNER?.toLowerCase() === 'true';
   };