Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency duende.accesstokenmanagement to 3.2.0 [security] #302

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 19, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
Duende.AccessTokenManagement (source) 3.1.1 -> 3.2.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2025-26620

Summary

Duende.AccessTokenManagement contains a race condition when requesting access tokens using the client credentials flow. Concurrent requests to obtain an access token using differing protocol parameters can return access tokens obtained with the wrong scope, resource indicator, or other protocol parameters. Such usage is somewhat atypical, and only a small percentage of users are likely to be affected.

Details

Duende.AccessTokenManagement can request access tokens using the client credentials flow in several ways. In basic usage, the client credentials flow is configured once and the parameters do not vary. In more advanced situations, requests with varying protocol parameters may be made by calling specific overloads of these methods:

  • HttpContext.GetClientAccessTokenAsync()
  • IClientCredentialsTokenManagementService.GetAccessTokenAsync()

There are overloads of both of these methods that accept a TokenRequestParameters object that customizes token request parameters. However, concurrent requests with varying TokenRequestParameters will result in the same token for all concurrent calls.

Upgrading

Most users can simply update the NuGet package to the latest version. Customizations of the IClientCredentialsTokenCache that derive from the default implementation (DistributedClientCredentialsTokenCache) will require a small code change, as its constructor was changed to add a dependency on the ITokenRequestSynchronization service. The synchronization service will need to be injected into the derived class and passed to the base constructor.

Impact

The impact of this vulnerability depends on how Duende.AccessTokenManagement is used and on the security architecture of the solution. Most users will not be vulnerable to this issue. More advanced users may run into this issue by calling the methods specified above with customized token request parameters. The impact of obtaining an access token with different than intended protocol parameters will vary depending on application logic, security architecture, and the authorization policy of the resource servers.

Thank you to Michael Dimoudis of PageUp for finding this issue and responsibly disclosing it!


Release Notes

DuendeSoftware/foss (Duende.AccessTokenManagement)

v3.2.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

Trivy image scan report

ghcr.io/chgl/fhir-server-exporter:pr-302 (ubuntu 24.04)

No Vulnerabilities found

No Misconfigurations found

opt/fhir-server-exporter/FhirServerExporter.deps.json

No Vulnerabilities found

No Misconfigurations found

opt/fhir-server-exporter/packages.lock.json

No Vulnerabilities found

No Misconfigurations found

usr/share/dotnet/shared/Microsoft.AspNetCore.App/9.0.2/Microsoft.AspNetCore.App.deps.json

No Vulnerabilities found

No Misconfigurations found

usr/share/dotnet/shared/Microsoft.NETCore.App/9.0.2/Microsoft.NETCore.App.deps.json

No Vulnerabilities found

No Misconfigurations found

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.04s
✅ CSHARP csharpier 5 2 0 0.96s
✅ CSHARP dotnet-format yes yes no 26.6s
✅ CSHARP roslynator 3 0 0 34.02s
✅ DOCKERFILE hadolint 1 0 0.11s
✅ EDITORCONFIG editorconfig-checker 45 0 0.12s
✅ JSON jsonlint 13 0 0.3s
✅ JSON prettier 13 3 0 1.75s
✅ JSON v8r 13 0 6.06s
✅ MARKDOWN markdownlint 2 0 0 0.92s
✅ REPOSITORY checkov yes no 18.68s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.32s
✅ REPOSITORY kics yes no 10.02s
✅ REPOSITORY secretlint yes no 0.66s
✅ REPOSITORY syft yes no 1.3s
✅ REPOSITORY trivy yes no 6.41s
✅ REPOSITORY trivy-sbom yes no 0.1s
✅ REPOSITORY trufflehog yes no 1.82s
✅ YAML prettier 15 0 0 0.84s
✅ YAML v8r 15 0 10.85s
✅ YAML yamllint 15 0 0.56s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@chgl chgl merged commit ced6960 into master Feb 20, 2025
16 checks passed
@renovate renovate bot deleted the renovate/nuget-duende.accesstokenmanagement-vulnerability branch February 20, 2025 07:59
chgl pushed a commit that referenced this pull request Feb 20, 2025
## [2.3.30](v2.3.29...v2.3.30) (2025-02-20)

### Miscellaneous Chores

* **deps:** update dependency duende.accesstokenmanagement to 3.2.0 [security] ([#302](#302)) ([ced6960](ced6960))
@chgl
Copy link
Owner

chgl commented Feb 20, 2025

🎉 This PR is included in version 2.3.30 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@chgl chgl added the released label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant