Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nitsirks needs to review this change
The MLDSA RTL correctly enters the zeroization flow, but the last read data remains on the read ports after zeroization completes. This occurs because the read data port retains the last-read value just before zeroization.
To prevent this, I enforce a read operation at address zero during zeroization. As a result, three clock cycles after receiving the zeroization command, the read port outputs data from address zero, which has already been cleared by the memory zeroization routine.
This ensures that no stale data remains on the read ports post-zeroization. This also ensures that read data port is zeroized at the 3rd clock cycle after receiving the zeroization command.